siddharthd
030490efa3
ci / lint-test (push) Successful in 41s
getPendingReconciliations treated every unreconciled manual transaction as awaiting a matching statement row. Cash never appears on a statement, so a cash entry sat in the queue indefinitely being offered matches within 3 days and 1% on amount - and accepting one is silently destructive: reconciled manual rows are filtered out of every query, so the cash spend disappears while the card transaction it matched claims to be that same spend. Migration 0016 adds transactions.payment_method (card | cash | bank_transfer | other, NULL = unknown) with a CHECK constraint and a partial index. The notCash() fragment excludes cash from both halves of the reconciliation query - the pending list and the candidate match subquery, which aliases the manual row as m. Only cash is excluded. Bank transfers do appear on a statement now that transaction accounts are imported, and NULL means unknown, so both stay candidates and every pre-existing row behaves exactly as before. ATM withdrawals deliberately stay categorised as spend rather than transfers. Treating them as transfers is only correct if every cash purchase is logged; with partial logging it silently deletes the unlogged remainder from spend.
1.2 KiB
1.2 KiB
| 1 | TransferWise ID | Date | Date Time | Amount | Currency | Description | Payment Reference | Running Balance | Exchange From | Exchange To | Exchange Rate | Payer Name | Payee Name | Payee Account Number | Merchant | Card Last Four Digits | Card Holder Full Name | Attachment | Note | Total fees | Exchange To Amount | Transaction Type | Transaction Details Type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2 | TRANSFER-1562381704 | 31-05-2025 | 31-05-2025 10:35:03.049 | -16718.38 | AUD | Sent money to Siddharth Bose (fee: 1.00 AUD) | Sent via Wise | 0.00 | Siddharth Bose | 408556264 | 1.00 | DEBIT | TRANSFER | ||||||||||
| 3 | FEE-TRANSFER-1562381704 | 31-05-2025 | 31-05-2025 10:35:03.048 | -1.00 | AUD | Wise Charges for: TRANSFER-1562381704 | Sent via Wise | 16718.38 | Wise | 0 | DEBIT | TRANSFER | |||||||||||
| 4 | BALANCE-3505957179 | 31-05-2025 | 31-05-2025 10:32:45.687 | 16719.38 | AUD | Converted 10,783.16 USD to 16,719.38 AUD | 16719.38 | USD | AUD | 1.55485 | 0.00 | 16719.38 | CREDIT | CONVERSION | |||||||||
| 5 | BANK_DETAILS_ORDER_CHECKOUT-invoice-17067107 | 22-04-2025 | 22-04-2025 21:45:08.441 | -22.00 | AUD | Wise bank details acquisition | 0.00 | 0.00 | DEBIT | UNKNOWN | |||||||||||||
| 6 | TRANSFER-1506981660 | 22-04-2025 | 22-04-2025 21:45:07.288 | 22.00 | AUD | Topped up account | 22.00 | 0.00 | CREDIT | MONEY_ADDED |