siddharthd
030490efa3
ci / lint-test (push) Successful in 41s
getPendingReconciliations treated every unreconciled manual transaction as awaiting a matching statement row. Cash never appears on a statement, so a cash entry sat in the queue indefinitely being offered matches within 3 days and 1% on amount - and accepting one is silently destructive: reconciled manual rows are filtered out of every query, so the cash spend disappears while the card transaction it matched claims to be that same spend. Migration 0016 adds transactions.payment_method (card | cash | bank_transfer | other, NULL = unknown) with a CHECK constraint and a partial index. The notCash() fragment excludes cash from both halves of the reconciliation query - the pending list and the candidate match subquery, which aliases the manual row as m. Only cash is excluded. Bank transfers do appear on a statement now that transaction accounts are imported, and NULL means unknown, so both stay candidates and every pre-existing row behaves exactly as before. ATM withdrawals deliberately stay categorised as spend rather than transfers. Treating them as transfers is only correct if every cash purchase is logged; with partial logging it silently deletes the unlogged remainder from spend.
844 B
844 B
| 1 | TransferWise ID | Date | Date Time | Amount | Currency | Description | Payment Reference | Running Balance | Exchange From | Exchange To | Exchange Rate | Payer Name | Payee Name | Payee Account Number | Merchant | Card Last Four Digits | Card Holder Full Name | Attachment | Note | Total fees | Exchange To Amount | Transaction Type | Transaction Details Type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2 | CARD-2958747517 | 01-10-2025 | 01-10-2025 09:03:26.018 | -30.00 | AUD | Card transaction of 76.00 AUD issued by Air India Limited Gurugram | 0.00 | Air India Limited Gurugram | 7824 | Siddharth Bose | 0.00 | DEBIT | CARD | ||||||||||
| 3 | TRANSFER-1738581938 | 25-09-2025 | 25-09-2025 23:10:05.406 | 30.09 | AUD | Topped up account | 30.00 | 0.09 | CREDIT | MONEY_ADDED | |||||||||||||
| 4 | FEE-TRANSFER-1738581938 | 25-09-2025 | 25-09-2025 23:10:05.405 | -0.09 | AUD | Wise Charges for: TRANSFER-1738581938 | -0.09 | 0 | DEBIT | MONEY_ADDED |